Repository navigation
Heap Sort: .NET 10, copy-per-call benchmark, stronger tests - #2376
Open
vladimir-pecanac-main wants to merge 1 commit into
Open
vladimir-pecanac-main wants to merge 1 commit into
vladimir-pecanac-main wants to merge 1 commit into
Conversation
Move both projects to net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. The benchmark moves into HeapSortBenchmarks, which copies the generated input into a work array on every call, so the random case no longer sorts an already sorted array after the first call. SortArray takes (array, size) as the article prints it. Tests use (expected, actual) order and cover the article example, empty, sorted, identical and random input checked against Array.Sort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves csharp-algorithms/HeapSort to net10.0 with BenchmarkDotNet 0.15.8, MSTest 4.5.2, Microsoft.NET.Test.Sdk 18.11.0 and coverlet.collector 10.1.0. The benchmark now lives in its own HeapSortBenchmarks class that copies the generated input into a work array on every call, because the old benchmark sorted its argument array in place and every call after the first measured an already sorted array. SortArray takes (array, size) as the article prints it, Program.cs passes args to BenchmarkRunner, and the tests use (expected, actual) order and cover the article's example, empty, sorted, identical and random input checked against Array.Sort.